Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spring jar security vulnerabilities #24112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NivinCS
Copy link

@NivinCS NivinCS commented Nov 21, 2024

Description

Fixing OSS CVEs for critical, high, and medium transitive vulnerabilities in the benchto-driver jar originating from Spring JARs

Motivation and Context

CVE-2016-1000027
CVE-2018-1272
CVE-2022-22970
CVE-2024-22243
CVE-2024-22259
CVE-2021-22096
CVE-2024-8184
CVE-2024-6763
CVE-2021-22060
CVE-2024-22262
CVE-2021-22096
CVE-2023-20883
WS-2021-0170
CVE-2018-1199
CVE-2022-22965
CVE-2024-6763
CVE-2015-5211
CVE-2015-3192
CVE-2022-27772
CVE-2020-5421
CVE-2024-38809
CVE-2022-22970

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==
Security Changes
* Fix for `CVE-2016-1000027 <https://www.mend.io/vulnerability-database/CVE-2016-1000027>`_. :pr:`24112`
* Fix for `CVE-2018-1272 <https://www.mend.io/vulnerability-database/CVE-2018-1272>`_. :pr:`24112`
* Fix for `CVE-2022-22970 <https://www.mend.io/vulnerability-database/CVE-2022-22970>`_. :pr:`24112`
* Fix for `CVE-2024-22243 <https://www.mend.io/vulnerability-database/CVE-2024-22243>`_. :pr:`24112`
* Fix for `CVE-2024-22259 <https://www.mend.io/vulnerability-database/CVE-2024-22259>`_. :pr:`24112`
* Fix for `CVE-2021-22096 <https://www.mend.io/vulnerability-database/CVE-2021-22096>`_. :pr:`24112`
* Fix for `CVE-2024-8184 <https://www.mend.io/vulnerability-database/CVE-2024-8184>`_. :pr:`24112`
* Fix for `CVE-2024-6763 <https://www.mend.io/vulnerability-database/CVE-2024-6763>`_. :pr:`24112`
* Fix for `CVE-2021-22060 <https://www.mend.io/vulnerability-database/CVE-2021-22060>`_. :pr:`24112`
* Fix for `CVE-2024-22262 <https://www.mend.io/vulnerability-database/CVE-2024-22262>`_. :pr:`24112`
* Fix for `CVE-2021-22096 <https://www.mend.io/vulnerability-database/CVE-2021-22096>`_. :pr:`24112`
* Fix for `CVE-2023-20883 <https://www.mend.io/vulnerability-database/CVE-2023-20883>`_. :pr:`24112`
* Fix for `CVE-2021-0170 <https://www.mend.io/vulnerability-database/CVE-2021-0170>`_. :pr:`24112`
* Fix for `CVE-2018-1199 <https://www.mend.io/vulnerability-database/CVE-2018-1199>`_. :pr:`24112`
* Fix for `CVE-2024-6763 <https://www.mend.io/vulnerability-database/CVE-2024-6763>`_. :pr:`24112`
* Fix for `CVE-2015-5211 <https://www.mend.io/vulnerability-database/CVE-2015-5211>`_. :pr:`24112`
* Fix for `CVE-2015-3192 <https://www.mend.io/vulnerability-database/CVE-2015-3192>`_. :pr:`24112`
* Fix for `CVE-2022-27772 <https://www.mend.io/vulnerability-database/CVE-2022-27772>`_. :pr:`24112`
* Fix for `CVE-2020-5421 <https://www.mend.io/vulnerability-database/CVE-2020-5421>`_. :pr:`24112`
* Fix for `CVE-2024-38809 <https://www.mend.io/vulnerability-database/CVE-2024-38809>`_. :pr:`24112`
* Fix for `CVE-2022-22965 <https://www.mend.io/vulnerability-database/CVE-2022-22965>`_. :pr:`24112`
* Fix for `CVE-2022-22970 <https://www.mend.io/vulnerability-database/CVE-2022-22970>`_. :pr:`24112`

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 21, 2024
@prestodb-ci prestodb-ci requested review from a team and jp-sivaprasad and removed request for a team November 21, 2024 10:47
@steveburnett
Copy link
Contributor

Suggest adding a release note entry that links to the CVE. Something in the format of the following example:

== RELEASE NOTES ==
Security Changes
* Upgrade okio to 3.6.0 in response to `CVE-2023-3635 <https://github.com/advisories/GHSA-w33c-445m-f8w7>`_. :pr:`23796`

jp-sivaprasad
jp-sivaprasad previously approved these changes Nov 21, 2024
Copy link
Contributor

@jp-sivaprasad jp-sivaprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add references to CVEs that are fixed.

@NivinCS NivinCS marked this pull request as ready for review November 22, 2024 09:31
@NivinCS NivinCS requested a review from a team as a code owner November 22, 2024 09:31
jp-sivaprasad
jp-sivaprasad previously approved these changes Nov 22, 2024
@NivinCS
Copy link
Author

NivinCS commented Nov 23, 2024

Please add references to CVEs that are fixed.

Done

@NivinCS
Copy link
Author

NivinCS commented Nov 23, 2024

Suggest adding a release note entry that links to the CVE. Something in the format of the following example:

== RELEASE NOTES ==
Security Changes
* Upgrade okio to 3.6.0 in response to `CVE-2023-3635 <https://github.com/advisories/GHSA-w33c-445m-f8w7>`_. :pr:`23796`

Done

@tdcmeehan
Copy link
Contributor

Please squash these commits and make sure the commit message follows our guidelines in contributing.

Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NivinCS Please also read https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines and update the release note accordingly. The phrase should start with Fix...
Also the PR message should also use imperative present tense.

@NivinCS NivinCS changed the title oss cve fix for spring jars Fix spring jar security vulnerabilities Nov 26, 2024
@NivinCS NivinCS force-pushed the cve-fix-oss-spring branch 3 times, most recently from e8cabf9 to 7f1ad6c Compare November 26, 2024 05:54
@NivinCS
Copy link
Author

NivinCS commented Nov 26, 2024

@NivinCS Please also read https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines and update the release note accordingly. The phrase should start with Fix... Also the PR message should also use imperative present tense.

Done

@NivinCS
Copy link
Author

NivinCS commented Nov 26, 2024

Please squash these commits and make sure the commit message follows our guidelines in contributing.

Done

Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release note
Fix for ...
==>
Fix ...
cc @steveburnett

@NivinCS
Copy link
Author

NivinCS commented Nov 27, 2024

Release note Fix for ... ==> Fix ... cc @steveburnett

Hi @steveburnett / @yingsu00 ,

Could you please confirm the same, as we get the general template for release note as below

== RELEASE NOTES ==

General Changes

  • ... :pr:12345
  • ... :pr:12345

Hive Connector Changes

  • ... :pr:12345
  • ... :pr:12345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants