Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Functional Test Failures #24123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed Functional Test Failures #24123

wants to merge 1 commit into from

Conversation

abevk2023
Copy link
Contributor

Resolves following failures in functional tests.

% ./mvnw test -pl presto-native-execution \
            -Dtest=com.facebook.presto.nativeworker.TestPrestoContainerBasicQueries \
            -DcoordinatorImage="presto-coordinator:latest" \
            -DworkerImage="presto-worker:latest"
[ERROR] Failures:
[ERROR] com.facebook.presto.nativeworker.TestPrestoContainerTpchConnectorQueries.init  
 java.io.IOException: File exists: testcontainers/coordinator/etc/catalog/tpch.properties
at com.facebook.presto.nativeworker.ContainerQueryRunnerUtils.createPropertiesFile(ContainerQueryRunnerUtils.java:208)
[ERROR]   TestPrestoContainerBasicQueries.testArraySortFunction:74->AbstractTestQueryFramework.assertQuery:174 Execution of 'actual' query failed: SELECT array_sort(ARRAY [5, 20, null, 5, 3, 50])
[ERROR]   TestPrestoContainerBasicQueries.testPresenceAndBasicFunctionality:37->AbstractTestQueryFramework.computeActual:134->AbstractTestQueryFramework.computeActual:139 » Runtime java.sql.SQLException: ResultSet is closed
[INFO]
[ERROR] Tests run: 4, Failures: 2, Errors: 0, Skipped: 0

== NO RELEASE NOTE ==

@abevk2023 abevk2023 requested a review from a team as a code owner November 22, 2024 16:24
@abevk2023 abevk2023 marked this pull request as draft November 22, 2024 16:24
@abevk2023 abevk2023 marked this pull request as ready for review November 25, 2024 08:21
tdcmeehan
tdcmeehan reviewed Nov 25, 2024
View reviewed changes
...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java Outdated
}

try (OutputStream output = new FileOutputStream(file);
try (OutputStream output = new FileOutputStream(file, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
try (OutputStream output = new FileOutputStream(file, false);
try (OutputStream output = new FileOutputStream(file);

Aren't these equivalent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Corrected.

...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java Outdated
String arrayElementTypeName = metaData.getColumnTypeName(i);
Type elementType = mapSqlTypeNameToType(arrayElementTypeName);
types.add(new ArrayType(elementType));
if (typeName.startsWith("ARRAY(") && typeName.endsWith(")")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use TypeSignature.parseTypeSignature to retrieve the base type name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdcmeehan tdcmeehan tdcmeehan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abevk2023 @tdcmeehan