Skip to content

[native] Fix MacOS build errors due to TimeZoneKey and sequenceId type #25286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Jun 11, 2025

Description

Fixes: #25267

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
== NO RELEASE NOTE ==

@majetideepak majetideepak requested a review from a team as a code owner June 11, 2025 13:55
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jun 11, 2025
@prestodb-ci prestodb-ci requested review from a team, nmahadevuni and ShahimSharafudeen and removed request for a team June 11, 2025 13:55
@majetideepak
Copy link
Collaborator Author

CC: @vhsu14 @spershin These changes are required to allow macos build to pass.
The fundamental issue is that long on macos is not compatible with int64_t and we need to fix this explicitly.

@majetideepak majetideepak requested a review from czentgr June 11, 2025 14:27
@majetideepak
Copy link
Collaborator Author

macos build passed. Linux tests are failing due to #25288
@vhsu14 @spershin any comments?
CC: @amitkdutta

Co-authored-by: Christian Zentgraf <czentgr@us.ibm.com>
@majetideepak
Copy link
Collaborator Author

Linux tests are now passing after rebase.
@amitkdutta, @aditi-pandit can we approve this?

Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @majetideepak

Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @majetideepak

@aditi-pandit aditi-pandit merged commit a3f2c3e into prestodb:master Jun 12, 2025
285 of 292 checks passed
@majetideepak majetideepak deleted the fix-build-macos branch June 12, 2025 16:09
@vhsu14
Copy link
Contributor

vhsu14 commented Jun 12, 2025

Thanks @majetideepak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native] Type mismatch build error in fromThrift() call with TimeZoneKey on MacOS
5 participants