-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Elasticsearch connector. Please check and suggest improvements. #3240
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
hi! sumanth232 |
+1 |
having a good look at this one. haven't gone all the way yet but it looks a reasonable starting point. or is this "elasticsearch-metadata.json" supposed to be assembled manually? |
Hi all! |
i've made a few changes and fixes over @sumanth232 work and currently have a working experimental version of the plugin on https://github.com/albertocsm/presto (master) |
I haven't no. Unfortunately, it doesn't look like I'm going to have time to work on one in the near future |
Thanks guys for the quick replies. |
@sumanth232 looks like you're not working on this anymore. If you still are please re-open! If someone else has finished an ES connector please open a separate PR. |
@albertocsm I was going through your version of this on : https://github.com/albertocsm/presto and was wondering:
Would really appreciate your help! |
What are you trying to accomplish? It's probably best if you open an issue in my fork. |
hi albertocsm: |
Hi.
Check albertocsm#30
…On Jul 10, 2017 15:09, "linqer" ***@***.***> wrote:
hi albertocsm:
could you tell me what is the right "metadata-uri" of ES connector?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3240 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADTL7nX7GzMn79NBSdm06UATojrN78r6ks5sMjB8gaJpZM4FVTTo>
.
|
I have written a basic connector using scan and scroll on the basis of Example-http connector.
It reads the schema and the table names from the elasticsearch-metadata.json through http.
The columns of a table are dynamically listed on the fly based on the sources of the table provided in the elasticsearch-metadata.json file. The columns are obtained from the mapping of the index/type provided in the source