Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Elasticsearch connector. Please check and suggest improvements. #3240

Closed
wants to merge 1 commit into from

Conversation

sumanth232
Copy link

I have written a basic connector using scan and scroll on the basis of Example-http connector.
It reads the schema and the table names from the elasticsearch-metadata.json through http.

The columns of a table are dynamically listed on the fly based on the sources of the table provided in the elasticsearch-metadata.json file. The columns are obtained from the mapping of the index/type provided in the source

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@chinaworld
Copy link

hi! sumanth232
Could you write a brief document for elasticsearch connector? I'm now testing the connector. Thank you!

@albertocsm
Copy link

+1

@albertocsm
Copy link

having a good look at this one. haven't gone all the way yet but it looks a reasonable starting point.
the schema retrieval based on the "elasticsearch-metadata.json" is not clear to me.
@sumanth232, can u plz clarify which ES endpoint are u refering to?

or is this "elasticsearch-metadata.json" supposed to be assembled manually?

@mateilucianstefan
Copy link

Hi all!
@sumanth232 are you still developing this?
@cberner did you start work on another implementation?

@albertocsm
Copy link

i've made a few changes and fixes over @sumanth232 work and currently have a working experimental version of the plugin on https://github.com/albertocsm/presto (master)
any input would be appreciated

@cberner
Copy link
Contributor

cberner commented Jan 19, 2016

I haven't no. Unfortunately, it doesn't look like I'm going to have time to work on one in the near future

@mateilucianstefan
Copy link

Thanks guys for the quick replies.
@albertocsm looks like we've taken the same path:) I will take a look at your repo soon and let you know.

@cberner
Copy link
Contributor

cberner commented May 3, 2016

@sumanth232 looks like you're not working on this anymore. If you still are please re-open! If someone else has finished an ES connector please open a separate PR.

@cberner cberner closed this May 3, 2016
@rohanarora0921
Copy link

@albertocsm I was going through your version of this on : https://github.com/albertocsm/presto and was wondering:

  1. If you could provide a basic example of DDL to create something in ElasticSearch using this connector through Presto.
  2. If you could explain the mapping between Presto Mapping->Java API for ES (QueryBuilder).

Would really appreciate your help!

@albertocsm
Copy link

What are you trying to accomplish?
What is the current status? Are you having trouble configuring the connector?

It's probably best if you open an issue in my fork.

@linqer
Copy link

linqer commented Jul 10, 2017

hi albertocsm:
could you tell me what is the right "metadata-uri" of ES connector?

@albertocsm
Copy link

albertocsm commented Jul 10, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.