Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ORC stripe prunning based on the DECIMAL predicates [without decimal coercions] #5190

Closed

Conversation

arhimondr
Copy link
Member

No description provided.

Andrii Rosa added 5 commits May 4, 2016 11:03
DomainTranslator extracts the TupleDomain for the simple
comparisons (>=, <=, =, <>, etc.). TupleDomain is further
used by connectors to implement the partition pruning
based on the query predicates.

If the column is compared with the value of narrower type
(column_double >= BIGINT '1'), the value can be easily
coerced to the wider type (column_double >= DOUBLE '1.0'),
and no workarounds are needed.

If the column is compared with the value of wider type
(column_integer >= DOUBLE '1.0'), the value must be
rounded to the narrower type.

Rounding algorithm for `column_integer >= const_double`
comparation was already implemented. This commit is a
generalization of that algoritm. Now in order to make some
types pair elligable for rounding and domain translation
the `SATURATED_FLOOR_CAST` operator must be registered for that
types pair.

Resolves: prestodb#5013
@ghost ghost added the CLA Signed label May 4, 2016
@martint martint self-assigned this May 4, 2016
@martint
Copy link
Contributor

martint commented May 7, 2016

Merged, thanks!

@martint martint closed this May 7, 2016
@arhimondr arhimondr deleted the stripe_prunning_decimal_orc_part_1 branch May 10, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants