-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary exchange RFC 0009 #29
base: main
Are you sure you want to change the base?
Conversation
@aditi-pandit @majetideepak This is the RFC for the binary exchange protocol. Can you please take a look before I move it out of the draft state? Thank you! |
Does BinX provide security and does it encrypt the exchange? |
It supports TLS encryption. Whenever SSL is configured for the HTTP server (http-server.https.enabled), it uses the same configuration and establishes TLS connections for the exchange. |
I understand why, in theory, using TCP sockets should be faster than HTTP. But can you go into more depth on where we are seeing the speedup from: is it the lack of headers on the page data? How the data is chunked in HTTP? |
I don't have a good answer to that. The initial starting point was an observation that the CPU load of the HTTP stack is relatively high. @yingsu00, you have observed that recently, too, right? Our assumption was that a simpler stack should be able to provide some improvement but we didn't conduct a detail analysis yet. |
If we haven't gotten to the bottom of that, IMO it would be worthwhile to do that, because I'm wondering if a simpler change could be done by optimizing how we are using HTTP. We don't know that until we root cause where in the HTTP stack we're spending the cycles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits and questions.
Like Tim, I am also curious to know where the wins are coming from given both Wangle and Proxygen use Folly under the hood.
5f824f3
to
b6d6b24
Compare
No description provided.