Correct wrong and misleading comments about enemy trainer AI #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix inaccurate comment.
Rephrase misleading comment about AI use of Rain Dance moves.
Rephrase misleading comments about AI use of Sunny Day moves.
AI_OPPORTUNIST checks enemy HP, not player.
Elaborate on AI use of "useful moves" in code comment.
Sync bug doc with Sunny Day moves list change.
Rangi42
reviewed
Nov 12, 2024
Rangi42
reviewed
Nov 12, 2024
Rangi42
reviewed
Nov 12, 2024
Rangi42
reviewed
Nov 12, 2024
Rangi42
reviewed
Nov 12, 2024
Rangi42
requested changes
Nov 12, 2024
|
Do I have to approve this or something? Sorry, I'm still learning. |
Rangi42
reviewed
Dec 25, 2024
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Rangi42
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the enemy trainer AI, I noticed that some comments are misleading or flat-out wrong. The corrections are simple and self-explanatory. No idea if I'm doing the pull request right, though.