Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify data table sizes with table_width and assert_table_length macros #806

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Verify data table sizes with table_width and assert_table_length macros #806

merged 3 commits into from
Mar 8, 2021

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Mar 4, 2021

This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739

@Rangi42 Rangi42 requested review from mid-kid and dannye March 4, 2021 03:23
@Rangi42
Copy link
Member Author

Rangi42 commented Mar 4, 2021

Once this is finalized it should also be applied to pokegold, pokered, and pokeyellow.

aaaaaa123456789
aaaaaa123456789 suggested changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@aaaaaa123456789 aaaaaa123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a very positive change; I've marked a few odd things here and there.

constants/gfx_constants.asm Outdated Show resolved Hide resolved
data/battle_tower/classes.asm Outdated Show resolved Hide resolved
data/moves/effects_pointers.asm Outdated Show resolved Hide resolved
data/pokemon/palettes.asm Show resolved Hide resolved
engine/items/item_effects.asm Outdated Show resolved Hide resolved
@Rangi42 Rangi42 changed the title Verify data table sizes with table_width and check_table_length macros Verify data table sizes with table_width and assert_table_length macros Mar 4, 2021
dannye
dannye reviewed Mar 4, 2021
View reviewed changes
data/battle_anims/objects.asm Show resolved Hide resolved
constants/pokemon_data_constants.asm Outdated Show resolved Hide resolved
constants/pokemon_data_constants.asm Show resolved Hide resolved
@Rangi42
Verify data table sizes with table_width and assert_table_length macros
40902ff 
This was discussed in pret#706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in pret#739
@Rangi42 Rangi42 requested a review from dannye March 4, 2021 23:16
@Rangi42 Rangi42 mentioned this pull request Mar 5, 2021
Merged
@Rangi42 Rangi42 merged commit e791c53 into pret:master Mar 8, 2021
pokepret pushed a commit that referenced this pull request Mar 8, 2021
Merge pull request #806 from Rangi42/tables
74f81c2 
Verify data table sizes with table_width and assert_table_length macros
@Rangi42 Rangi42 deleted the tables branch March 8, 2021 15:07
@Rangi42 Rangi42 mentioned this pull request Mar 8, 2021
Closed
@Rangi42 Rangi42 mentioned this pull request Apr 27, 2021
Closed
@gav-antula gav-antula mentioned this pull request Oct 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaaaaa123456789 aaaaaa123456789 aaaaaa123456789 requested changes

@dannye dannye dannye approved these changes

@mid-kid mid-kid Awaiting requested review from mid-kid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rangi42 @dannye @aaaaaa123456789