RGBDS syntax updates

[vulcandth]

Implementing the new RGBDS Macro Syntax. This was done using regex. It make compare OK. Although, Please review thoroughly to make sure I didn't change something I shouldn't have.

Please also reference: #686

• RGBDS PR for Pokecrystal
• RGBDS PR for Pokegold: RGBDS syntax updates pokegold#78
• RGBDS PR for Pokered: RGBDS syntax updates pokered#358
• RGBDS PR for Pokeyellow: RGBDS syntax updates pokeyellow#86
• RGBDS PR for Poketcg: RGBDS syntax updates poketcg#116
• RGBDS PR for Pokepinball: RGBDS syntax updates pokepinball#35
• RGBDS Commit for Poketcg2: pret/poketcg2@764c416

[Rangi42]

Looks good, thanks! I assume it was something like s/^([A-Za-z_][A-Za-z0-9_@#]*): MACRO/MACRO \1/g?

Please add DEF to constants in this PR as well. I thought that would be too disruptive, but after all, most constants are done with const and the DEFs would mostly be within macros anyway. A regex like s/^([A-Za-z_][A-Za-z0-9_@#]*\s+(?:EQU\b|EQUS\b|=|rb\b|rw\b|rl\b))/DEF \1/g should cover all of them, but then it'll be nice to manually indent ones inside of macros (since that's one reason rgbasm introduced the DEF syntax anyway).

[vulcandth]

@Rangi42 I added DEF in front of the constants. I have not yet indented the constants in the MACRO's. I plan to go back through an manually tackling that. Could you please give one or two examples of how you like it indented.. and i'll apply it to the rest.

EDIT: nevermind I saw in discord an example.

[Rangi42]

Oops, I forgot to get the new +=/-=/etc operators in that regex (like __deco_value__ += 1).

s/^([A-Za-z_][A-Za-z0-9_@#]*\s+[-+*/%<>&|^]=)/DEF \1/g will update them. Some also need indenting.

[Idain]

I still think that Regex is advanced sorcery, so I'm very impressed.

[Rangi42]

I think this is ready now. @aaaaaa123456789 @mid-kid want to review?

I still think that Regex is advanced sorcery, so I'm very impressed.

They're literally simpler than complete programming languages, it's just that they have a very dense syntax, and it can be hard to read which characters are regex language operators vs which are literal text. Python has a verbose regex mode that lets you space things out and add comments, like:

^                   # Start at the beginning of the line
(                   # Capture all this text so we can refer to it in the 'DEF \1' replacement
  [A-Za-z_]         # Constants start with a letter or '_'
  [A-Za-z0-9_@#] *  # Constants may then have letters, digits, '_'s, '@'s, or '#'s
  \s +              # At least one whitespace character between the constant and the operator
  [-+*/%<>&|^]      # The first character of '-=', '+=', '*=', etc
  =                 # The second character is always an '='
)

People have also made various alternative syntaxes that some might find easier to read/write.

[aaaaaa123456789]

Noticed a few minor things. Nice work!

[Rangi42]

Updating the MACRO and DEF syntaxes here looks good to me. It should wait to merge until all four repos are ready.

[vulcandth]

Noticed a couple things that still need fixing while doing pokegold.