Kanto Mon Names #79
Merged
Kanto Mon Names #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses issue "Japanese vs. English label names #77" TODO: Rename dirs/files, examples: gfx/pokemon/fushigidane/front.pic gfx/pokemon/fushigidane/back.pic gfx/intro/lizardon_1.2bpp Fix this: dex_order_alpha Align comments (Or remove them??), ex: menu_icons pokemon_constants
|
Thanks for getting this started! Constant value comments should stay, but they don't need the now-redundant English names. So |
Rangi42
reviewed
Oct 13, 2020
Rangi42
reviewed
Oct 13, 2020
plus a couple small fixes: GHOS -> GASTLY, etc
|
Anything else I'm missing? Do I need to re-order dex_order_alpha at all? Files and folders need renaming too still, yes? |
|
Yes, the TODO items you listed should be added, including renaming the |
ghost
marked this pull request as ready for review
Missed a few comments when changing Kanto mons names to English
|
Cool, I think this is ready now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relabeling Kanto mons to have their canon English names, being consistent with pokegold/red/etc
addressing issue "Japanese vs. English label names #77"
TODO:
Rename dirs/files, examples:
gfx/pokemon/fushigidane/front.pic
gfx/pokemon/fushigidane/back.pic
gfx/intro/lizardon_1.2bpp
Fix this (??):
dex_order_alpha
Align comments (Or remove them??), ex:
menu_icons
pokemon_constants