-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for printers with TSPL protocol #73
base: master
Are you sure you want to change the base?
Conversation
tested and working usb connection
removed todo
Oh wow, nice work! We'll look into this in detail in the next weeks, please have a little patience :) As we don't have a TSPL printer, we will probably need to mark the integration as "experimental" to clarify that we cannot provide support on it to our customers. Implementing Floyd-Steinberg in the pretixPRINT layer is something we deliberately not do in the other protocols because in our experience it is a quite significant performance difference, but it's also not something I'd have too much trouble with for this one, it just feels a little inconsistent. |
Thanks! I understand, that dithering in pretixPRINT feels wrong and admittedly is a bit slow on the older devices I tested (sunmi v2 pro). So yeah, it was a tradeoff in favor of performance. These printers just can't dither, the protocol explicitly only accepts binary bitmap data. (pg 43: https://shop.mediaform.de/media/wysiwyg/downloads/armilla/TSC_TSPL_TSPL2_Programming.pdf) What do you think about putting dithering as an option into the settings? Defaulting to the much quicker threshold-dithering. Let me know when you get a chance to have a look at it. I appreciate your feedback and am in no hurry, so take your time :) |
Added support for TSPL protocol.
Allows printing to TSC-based printers including the majority of cheap generic thermal label printers, for usually less than 100€ (e.g. TSC, Yinleader, Vretti, Vevor, Phomemo, …)
Features:
Seeking help and opinion:
This is my first pull request, so please forgive any foolish mistakes. I'm open to feedback, roasting and rejection.