receive and fallback support #244
Conversation
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 84 84
Lines 677 680 +3
Branches 115 116 +1
=======================================
+ Hits 675 678 +3
Misses 2 2 Continue to review full report at Codecov.
|
src/nodes/FunctionDefinition.js
Outdated
| // | ||
| // An neat idea would be to rely on the pragma and enforce it but for the | ||
| // moment this will do. | ||
| return options.originalText.slice( |
There was a problem hiding this comment.
should we enforce here that we are only returning function and fallback and not, for instance, facepalm (yes it's 8 letters)?
There was a problem hiding this comment.
Can do that but will mess with coverage though as there’s no chance for us to trigger the parser to have facepalm as a function definition
There was a problem hiding this comment.
ok I updated it to be a bit more explicit. I understand clever solutions might be too clever in the long run 😆
There was a problem hiding this comment.
hahaha, I've pushed a commit, what do you think? something in between?
There was a problem hiding this comment.
yup, this way we'll also know if solidity inserts a new keyword as undefined doesn't silently print in concat
There was a problem hiding this comment.
I go ahead and merge then ok?
solves #242
receivewas easy but forfallbackI rely on theoriginalText