-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use flat config for the project's eslint configuration #615
Conversation
|
@BPScott See also https://github.com/mdx-js/eslint-mdx/tree/master/packages/eslint-plugin-mdx#flat-config, https://github.com/mdx-js/eslint-mdx/tree/master/packages/eslint-plugin-mdx#mdxremark and https://github.com/prettier/eslint-plugin-prettier/blob/master/.remarkrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add mdx plugin back.
Gotcha, I hadn't clocked that eslint-plugin-mdx also lints against the markdowny portions of the markdown file rather than just the codeblocks. I'll add it back. |
a0cf315
to
ee059f1
Compare
ee059f1
to
c576267
Compare
There we go, I believe that's the markdown stuff put back properly. That last rebase was tidying up the wording of the global ignores block at the bottom and some variable renaming. @JounQin I've tagged you for one last re-review if you'd be so kind. |
c576267
to
7652e18
Compare
This shall let us dogfood the recommended eslint config when we add it
7652e18
to
88bb87e
Compare
Convert the project's eslint config to the flat style.
This shall let us dogfood the recommended eslint config when we add it.
This is a 1:1 migration, with the exception of adding
.github/ISSUE_TEMPLATE.md
to the ignores. I'm not sure what I've managed to do here, but it seems we weren't linting that before but now we are.