Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Documentation Update #2194

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

WazzaJB
Copy link
Contributor

@WazzaJB WazzaJB commented Jun 13, 2023

As per the conversation on the following issue, this issues seeks to include some additional details regarding caveats with VS Code.

#1730 (comment)

I am open to any and all improvements here and would welcome some additional testing, I have prepared a codespace repository to make this easier should anyone wish to take a look (just click the following link and press . on your keyboard).

https://github.com/WazzaJB/prettier-php-sample

I have used PNPM in the repository, but also trialed this there with npm and yarn (in case module resolution worked differently at all).

Copy link

@mpagels mpagels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc update resolved my problems, especially with prettiers overrides option.

Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WazzaJB, thanks for the contribution, and sorry about the late review!

@czosel czosel merged commit 246472e into prettier:main Aug 18, 2023
@WazzaJB
Copy link
Contributor Author

WazzaJB commented Aug 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants