Skip to content

Conversation

@JounQin
Copy link
Member

@JounQin JounQin commented Aug 12, 2022

What:

Please view #437 for more details.

Why:

This PR is only a workaround to cut a major release for stupid semantic-release, see also #438 (comment)

How:

N/A

@JounQin JounQin requested a review from kylemh August 12, 2022 23:54
@JounQin JounQin self-assigned this Aug 12, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #439 (afb09e7) into master (25fcce1) will not change coverage.
The diff coverage is n/a.

❗ Current head afb09e7 differs from pull request most recent head ebfdde3. Consider uploading reports for the commit ebfdde3 to get more accurate results

@@            Coverage Diff            @@
##            master      #439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          161       161           
  Branches        27        27           
=========================================
  Hits           161       161           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JounQin JounQin merged commit 32ca804 into prettier:master Aug 13, 2022
@JounQin JounQin deleted the chore/release branch August 13, 2022 00:09
@idahogurl
Copy link
Collaborator

Nope. I suggest you try sematic-release locally on master before you do another PR.

12:10:06 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The commit should not trigger a release
[12:10:06 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: feat!: bump all upgradable (dev)Dependencies except pure ESM (#437)

@JounQin
Copy link
Member Author

JounQin commented Aug 13, 2022

https://github.com/prettier/prettier-eslint-cli/runs/7815418434?check_suite_focus=true#step:6:35

[12:10:06 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: BREAKING CHANGE: bump all upgradable (dev)Dependencies except pure ESM (#439)
[12:10:06 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The commit should not trigger a release
[12:10:06 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: feat!: bump all upgradable (dev)Dependencies except pure ESM (#437)
[12:10:06 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The commit should not trigger a release
[12:10:06 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analysis of 2 commits complete: no release
[12:10:06 AM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[12:10:06 AM] [semantic-release] › ℹ  There are no relevant changes, so no new version is released.

Stupid sematic-release, then I have no idea how to fix this. @idahogurl Any idea?

@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants