Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't work with eslint v8 #656

Closed
vingeraycn opened this issue Oct 28, 2021 · 12 comments · Fixed by #696
Closed

It doesn't work with eslint v8 #656

vingeraycn opened this issue Oct 28, 2021 · 12 comments · Fixed by #696
Labels

Comments

@vingeraycn
Copy link

Versions:

  • prettier-eslint version: 9.0.2
  • node version: 14
  • npm (or yarn) version: 1.22.5

Have you followed the debugging tips?

Yes

Relevant code or config

prettier-eslint '**/*.{ts,tsx}' --list-different

What I did:

What happened:
image

Reproduction repository:

Problem description:
It doesn't work with eslint v8

Suggested solution:
update with this document to adapting eslint v8.

@pjg
Copy link

pjg commented Nov 25, 2021

Dropping here a related issue and a working pull request in coc-eslint for reference: neoclide/coc-eslint#118

@talko-cervello
Copy link

Any updates?

idahogurl pushed a commit to idahogurl/prettier-eslint-formatter that referenced this issue Apr 18, 2022
BREAKING CHANGES: The `format` function is now asynchronous.
Closes prettier#656
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 14.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shellscape
Copy link

@kylemh thanks for taking this on. Is there any chance you can ping the part of the team in charge of prettier-atom? That's failing hard and they need an update.

@idahogurl
Copy link
Collaborator

@shellscape I'm not sure if the Prettier team works on any repo besides prettier. Kyle and I are just contributors on this project. With Atom being sunsetted on December 15, 2022, I don't think there will be further development on prettier-atom https://github.blog/2022-06-08-sunsetting-atom/

I suggest you move to another editor like VS Code. I made the switch years ago and I still run the Atom keyboard layout.

@shellscape
Copy link

Thanks for the reply. I'm waiting for Zed to mature and currently beta testing. I loathe VSCode. In the mean time, since prettier-atom is not being maintained and we do have until December this year, would be it possible to add a contributor that can keep it up to date? I'm happy to run my own fork but there's a community still out there in need.

@idahogurl
Copy link
Collaborator

@shellscape All someone needs to do is create a PR and then tag or message someone marked as a Collaborator to get it reviewed, merged, and deployed. That's what I did to become a collaborator.

P.S. I still miss Atom.

@shellscape
Copy link

@idahogurl we've tried. it's sat idle. prettier/prettier-atom#1271

@kylemh
Copy link
Collaborator

kylemh commented Aug 16, 2022

While we're collaborators in prettier-eslint and prettier-eslint-cli, we're not collaborators in prettier-atom and have no way of pushing it forward for you.

@shellscape
Copy link

@kylemh understood. Shared that in the hopes that it might be passed onto other teams or core team members. is there a private prettier slack, discord, or mailing list for the teams that you could help out the community by sharing this situation? we're coming up against crickets on the outside over here.

@kylemh
Copy link
Collaborator

kylemh commented Aug 16, 2022

There is not. We're a random collection of people that do what we can, when we can. We do this work exclusively without communicating beyond what you see on GitHub.

Your solution may need to be forking it and fixing it yourself.

@shellscape
Copy link

Man, that's a bummer. Even on the webpack core team we had mechanisms for other non-core individual teams and groups of collabs to talk to one another. I would have thought the Prettier org would be more organized given how huge the project is within the developer community these days. But thanks for the clarification.

Your solution may need to be forking it and fixing it yourself.

Way ahead of you. But that doesn't mean that I'm not going to stop trying to help the larger Atom community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants