feat(format): make format synchronous #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prettier's resolveConfig function has a .sync function that doesn't require async handling: https://github.com/prettier/prettier#prettierresolveconfigfilepath--options
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 191 191
Branches 32 32
=====================================
Hits 191 191
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Sep 8, 2017
kentcdodds
pushed a commit
that referenced
this pull request
Sep 8, 2017
Prettier's resolveConfig function has a .sync function that doesn't require async handling: https://github.com/prettier/prettier#prettierresolveconfigfilepath--options BREAKING CHANGE: the `format` function is now synchronous (again)
|
We could change it so it's under a |
|
Nah, I like this better anyway. |
|
I guess we were a bit eager to push version 8 of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier's resolveConfig function has a .sync function that doesn't require async handling:
https://github.com/prettier/prettier#prettierresolveconfigfilepath--options