chore(prettier): Take Prettier 2.4.0's jsxBracketSameLine → bracketSameLine #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meLine prettier/prettier@4992d9720, released in 2.4.0, deprecated the `jsxBracketSameLine` option in favor of a new, more generic option, `bracketSameLine`. See docs: https://prettier.io/docs/en/options.html#bracket-line This has caused a warning jsxBracketSameLine is deprecated. for people using Prettier 2.4.0+, if their ESLint config leads us to infer and use a value for jsxBracketSameLine. So, instead of inferring and using a value for jsxBracketSameLine, do so for the new bracketSameLine. In d8bf1e3, which we released in 14.0.0, we stopped supporting Prettier versions older than 2.5.1. That means we don't need to maintain backward-compatible code for users with Prettier <2.4.0, which doesn't have bracketSameLine. See discussion: prettier/prettier-eslint-cli#430 (comment)
|
LGTM. Let's put this as a breaking change, the need for Prettier 2.4+. If that's the case, we have to bump the package to 15.0.0. Whoever squashes and merges this, make sure to follow the conventional commit and put the breaking change in the message box as shown in the first example here: https://www.conventionalcommits.org/en/v1.0.0-beta.2/#examples |
|
i'll do this tn ehhhh tomorrow |
|
|
|
🎉 This PR is included in version 15.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for the review, both of you! 🙂 |
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
May 26, 2022
TODO: find out what we actually want :) and finish commit message Following the eagerly awaited resolution of prettier/prettier-eslint-cli#304 - add some @babel/ deps for peer-dep requirements - resolutions line to get prettier/prettier-eslint#749 Fixes: zulip#4254
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 2, 2022
Following the eagerly awaited resolution of prettier/prettier-eslint-cli#304 . And adjust our ESLint config so that we can do this with no new ESLint errors or suppressions. After this, we'll un-ignore the rules under "New rules we want", one by one, which will mean fixing the code that doesn't yet follow each rule. Greg says, about the formatting changes: zulip#5393 (review) > The formatting changes from the Prettier upgrade look fine. Some > code gets nicer (like `foo.bar().baz()` going on one line), some > gets less nice (like a lot of stuff getting an extra level of > indentation). I'm not sure I like it better on net; but Prettier > is designed as a take-it-or-leave-it package, and I don't have a > better alternative nor want to be stuck on an old version. So > 🤷 The added @babel/* deps are to satisfy peer-dependency requirements. The resolutions line gets us prettier/prettier-eslint#749 and can be removed when prettier-eslint-cli bumps its prettier-eslint version.
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 2, 2022
Following the eagerly awaited resolution of prettier/prettier-eslint-cli#304 . And adjust our ESLint config so that we can do this with no new ESLint errors or suppressions. After this, we'll un-ignore the rules under "New rules we want", one by one, which will mean fixing the code that doesn't yet follow each rule. Greg says, about the formatting changes: zulip#5393 (review) > The formatting changes from the Prettier upgrade look fine. Some > code gets nicer (like `foo.bar().baz()` going on one line), some > gets less nice (like a lot of stuff getting an extra level of > indentation). I'm not sure I like it better on net; but Prettier > is designed as a take-it-or-leave-it package, and I don't have a > better alternative nor want to be stuck on an old version. So > 🤷 The added @babel/* deps are to satisfy peer-dependency requirements. The resolutions line gets us prettier/prettier-eslint#749 and can be removed when prettier-eslint-cli bumps its prettier-eslint version.
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 3, 2022
Following the eagerly awaited resolution of prettier/prettier-eslint-cli#304 . And adjust our ESLint config so that we can do this with no new ESLint errors or suppressions. After this, we'll un-ignore the rules under "New rules we want", one by one, which will mean fixing the code that doesn't yet follow each rule. Greg says, about the formatting changes: zulip#5393 (review) > The formatting changes from the Prettier upgrade look fine. Some > code gets nicer (like `foo.bar().baz()` going on one line), some > gets less nice (like a lot of stuff getting an extra level of > indentation). I'm not sure I like it better on net; but Prettier > is designed as a take-it-or-leave-it package, and I don't have a > better alternative nor want to be stuck on an old version. So > 🤷 The added @babel/* deps are to satisfy peer-dependency requirements. The resolutions line gets us prettier/prettier-eslint#749 and can be removed when prettier-eslint-cli bumps its prettier-eslint version.
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 8, 2022
Following the eagerly awaited resolution of prettier/prettier-eslint-cli#304 . And adjust our ESLint config so that we can do this with no new ESLint errors or suppressions. After this, we'll un-ignore the rules under "New rules we want", one by one, which will mean fixing the code that doesn't yet follow each rule. Greg says, about the formatting changes: zulip#5393 (review) > The formatting changes from the Prettier upgrade look fine. Some > code gets nicer (like `foo.bar().baz()` going on one line), some > gets less nice (like a lot of stuff getting an extra level of > indentation). I'm not sure I like it better on net; but Prettier > is designed as a take-it-or-leave-it package, and I don't have a > better alternative nor want to be stuck on an old version. So > 🤷 The added @babel/* deps are to satisfy peer-dependency requirements. The resolutions line gets us prettier/prettier-eslint#749 and can be removed when prettier-eslint-cli bumps its prettier-eslint version.
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 9, 2022
Following the eagerly awaited resolution of prettier/prettier-eslint-cli#304 . And adjust our ESLint config so that we can do this with no new ESLint errors or suppressions. After this, we'll un-ignore the rules under "New rules we want", one by one, which will mean fixing the code that doesn't yet follow each rule. Greg says, about the formatting changes: zulip#5393 (review) > The formatting changes from the Prettier upgrade look fine. Some > code gets nicer (like `foo.bar().baz()` going on one line), some > gets less nice (like a lot of stuff getting an extra level of > indentation). I'm not sure I like it better on net; but Prettier > is designed as a take-it-or-leave-it package, and I don't have a > better alternative nor want to be stuck on an old version. So > 🤷 The added @babel/* deps are to satisfy peer-dependency requirements. The resolutions line gets us prettier/prettier-eslint#749 and can be removed when prettier-eslint-cli bumps its prettier-eslint version.
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 9, 2022
Following the eagerly awaited resolution of prettier/prettier-eslint-cli#304 . And adjust our ESLint config so that we can do this with no new ESLint errors or suppressions. After this, we'll un-ignore the rules under "New rules we want", one by one, which will mean fixing the code that doesn't yet follow each rule. Greg says, about the formatting changes: zulip#5393 (review) > The formatting changes from the Prettier upgrade look fine. Some > code gets nicer (like `foo.bar().baz()` going on one line), some > gets less nice (like a lot of stuff getting an extra level of > indentation). I'm not sure I like it better on net; but Prettier > is designed as a take-it-or-leave-it package, and I don't have a > better alternative nor want to be stuck on an old version. So > 🤷 The added @babel/* deps are to satisfy peer-dependency requirements. The resolutions line gets us prettier/prettier-eslint#749 and can be removed when prettier-eslint-cli bumps its prettier-eslint version. And run $ tools/tsflower unpack $ tools/tsflower pack to update TsFlower's output for the new Prettier version and rebase the patches atop that. I see some churn in the patches where it looks like a Git version is printed at the bottom, and mine differs from Greg's, hmm.
gnprice
pushed a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 9, 2022
Following the eagerly awaited resolution of prettier/prettier-eslint-cli#304 . And adjust our ESLint config so that we can do this with no new ESLint errors or suppressions. After this, we'll un-ignore the rules under "New rules we want", one by one, which will mean fixing the code that doesn't yet follow each rule. Greg says, about the formatting changes: zulip#5393 (review) > The formatting changes from the Prettier upgrade look fine. Some > code gets nicer (like `foo.bar().baz()` going on one line), some > gets less nice (like a lot of stuff getting an extra level of > indentation). I'm not sure I like it better on net; but Prettier > is designed as a take-it-or-leave-it package, and I don't have a > better alternative nor want to be stuck on an old version. So > 🤷 The added @babel/* deps are to satisfy peer-dependency requirements. The resolutions line gets us prettier/prettier-eslint#749 and can be removed when prettier-eslint-cli bumps its prettier-eslint version. And run $ tools/tsflower unpack $ tools/tsflower pack to update TsFlower's output for the new Prettier version and rebase the patches atop that. I see some churn in the patches where it looks like a Git version is printed at the bottom, and mine differs from Greg's, hmm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettier/prettier@4992d9720, released in 2.4.0, deprecated the
jsxBracketSameLineoption in favor of a new, more generic option,bracketSameLine. See docs:https://prettier.io/docs/en/options.html#bracket-line
This has caused a warning
for people using Prettier 2.4.0+, if their ESLint config leads us to
infer and use a value for jsxBracketSameLine.
So, instead of inferring and using a value for jsxBracketSameLine,
do so for the new bracketSameLine.
In d8bf1e3, which we released in 14.0.0, we stopped supporting
Prettier versions older than 2.5.1. That means we don't need to
maintain backward-compatible code for users with Prettier <2.4.0,
which doesn't have bracketSameLine.
See discussion:
prettier/prettier-eslint-cli#430 (comment)