Multi root (vscode next)

[CiGit]

Adapt settings for resource usage. ie settings which are relevant to a file.

remove rootpath usage.

Will need to make test on an insider version. (Welcome testers !)

fix #243

Edit: Made some tests on insider with 2 folders. Was working 😄

[felixfbecker]

Nice! Is there a way to enable prettier only per folder? I.e. a folder setting "prettier.enable": true/false. That would be especially important for multi-folder workspaces to not cause unwanted formatting changes

[azz]

Going to add multi-root ready?

#243 (comment)

[CiGit]

eventually yes.

Just wanted to really test it first.

[CiGit]

@felixfbecker This is not possible. Either you register a formatter for the entire instance or you don't.
However .prettierignore may do what you want.

[felixfbecker]

@CiGit

Either you register a formatter for the entire instance or you don't

Sorry I don't understand. Why is this not possible (but .prettierignore is)?

[CiGit]

I may have misunderstood you question. To me you wanted to be able to use any other formatter (at least the default one) on other folder. ie enable the extension per folder. This may be a feature from vscode.

If it's just a toggle, on/off, this may be possible, but I would be against it. #199 would already do it. Once implemented.

[azz]

If you're looking to turn off formatOnSave for a given workspace folder, I believe you can just put "formatOnSave": false in .vscode/settings.json in that folder and it will work.

[felixfbecker]

I think #199 would solve it. "Format document" needs to use a different formatter depending on the workspace folder.

[rothfels]

@felixfbecker afaict a formatter extension must register itself (and therefore override default formatters shipped w/ vscode) before we have specific information about the workspaces in a multi-root setting. The .prettierignore option works to disable prettier formatting on a workspace root, but the prettier extension will have still been registered and overridden the default formatter (even though it's a noop on ignored files). I don't think there's currently a way to dynamically register a formatter extension based on properties/config of the workspace root. This is unfortunate because (especially in a multi-root context) I imagine many people will run into an issue lacking the ability to run multiple formatters for the same language id simultaneously.

microsoft/vscode#15611 might be the appropriate solution

[CiGit]

Ready to review! I've nothing more to test or add

[RobinMalfait]

Code looks good to me! Couldn't test functionally because I forgot my charger...