prettier 1.9 and config handling #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* proseWrap config change * Don't merge vscode's option in prettierConfig * dependencies bump + arrowParens config + requireConfig config. Format only files with a prettierconfig
azz
approved these changes
Dec 6, 2017
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "ignore": "^3.3.7", | ||
| "prettier": "1.9.0", |
|
Could you also bump the version of prettier-eslint if there is a new version? |
CiGit
commented
Dec 6, 2017
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "ignore": "^3.3.7", | ||
| "prettier": "1.9.0", | ||
| "prettier-eslint": "^8.2.4", |
There was a problem hiding this comment.
@RobinMalfait 8.2.0 -> 8.2.4
There is also a 8.2.5 now
There was a problem hiding this comment.
Whoops, didn't see that!
Adapt stylelint integration
|
Deprecated old options, notably "postcss" and updated stylelint check with new styles. |
|
Good for a review ! |
|
Does someone see something more we would need for a 1.0.0 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json validation forother PRprettierrc.jsonBreak
Don't handle deprecated options. Workaround: prettierconfig