-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unstable object expansion within function call #821
Labels
locked-due-to-inactivity
Please open a new issue and fill out the template instead of commenting.
type:bug
Issues identifying ugly output, or a defect in the program
Comments
vjeux
added
the
type:bug
Issues identifying ugly output, or a defect in the program
label
Feb 27, 2017
So it only happens within string templates? |
As far as I know, yes. I'm guessing it's due to the hackery we do with the removal of softlines and forcing objects to be expanded. |
Most likely, yeah. |
josephfrazier
added a commit
to josephfrazier/prettier
that referenced
this issue
May 22, 2017
These are related to the following issues: * prettier#1662 * prettier#821 * prettier#1183 * prettier#1626
josephfrazier
added a commit
to josephfrazier/prettier
that referenced
this issue
May 22, 2017
This fixes prettier#1662 and fixes prettier#1626 It also affects prettier#821 and prettier#1183
vjeux
pushed a commit
that referenced
this issue
May 22, 2017
I didn't close this from the commit message of 374a682, but I think it's actually fixed now: f(`${{
a: 4,
b: 9,
}}`); becomes: f(
`${{
a: 4,
b: 9
}}`
); which stays stable. |
Nice! |
lock
bot
added
the
locked-due-to-inactivity
Please open a new issue and fill out the template instead of commenting.
label
Jul 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
locked-due-to-inactivity
Please open a new issue and fill out the template instead of commenting.
type:bug
Issues identifying ugly output, or a defect in the program
turns into
then
https://prettier.github.io/prettier/#%7B%22content%22%3A%22f(%60%24%7B%7B%5Cn%20%20a%3A%204%2C%5Cn%20%20b%3A%209%2C%5Cn%7D%7D%60)%3B%5Cn%5Cnf(%5Cn%20%20%60%24%7B%7Ba%3A%204%2C%20b%3A%209%2C%7D%7D%60%5Cn)%3B%5Cn%22%2C%22options%22%3A%7B%22printWidth%22%3A80%2C%22tabWidth%22%3A2%2C%22singleQuote%22%3Afalse%2C%22trailingComma%22%3Afalse%2C%22bracketSpacing%22%3Afalse%2C%22jsxBracketSameLine%22%3Afalse%2C%22doc%22%3Afalse%7D%7D
The text was updated successfully, but these errors were encountered: