This repository has been archived by the owner on May 19, 2023. It is now read-only.
Reset rules rather than set them to a default #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the pull request! I'm going to mention this issue on a few other threads and leave it open for a week to see if others have changes they'd like to see. Then will release as a new major version. |
|
Great, I'm going to try and review the rules themselves soon to make sure they themselves are required. This is just step one to do some normalisation beforehand as I wasn't sure if you'd prefer one big PR with lots of rule changes or one PR per rule chnage. |
|
Like I mentioned in #124, I think what we really need is a better way to validate changes. Then we can group together rule changes with tests and examples to back them up. |
|
Released as v9. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some rules are set to match Prettier's behaviour but we should probably just reset them to avoid any conflicts like we do with other rules.
I'm also going to look at submitting another PR that goes through the current rules and making sure they don't conflict or have special cases to close #96. Would you rather this is done as one bigger PR or mutliple small ones, one for each rule change?