Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system upgrade #82

Merged

Conversation

serbanghita
Copy link
Contributor

  • Build system now uses Chrome Headless
  • Improved karma support for development
  • Tests use the sources from /src/ instead of /bin/
  • Test coverage uses Istanbul for a better future development process.

Signed-off-by: Serban Ghita serbanghita@gmail.com

* Improved karma support for development
* Tests use the sources from /src/ instead of /bin/
* Test coverage uses Istanbul for a better future development process.

Signed-off-by: Serban Ghita <serbanghita@gmail.com>
@serbanghita
Copy link
Contributor Author

@prettymuchbryce this will offer a better transition to convert the script to Typescript in the near future. Also we can write tests for new features in this upgraded env. Let me know your thoughts!

webpack.config.js Outdated Show resolved Hide resolved
@prettymuchbryce
Copy link
Owner

Thanks for this contribution. Chrome headless and a dev script is a really nice quality of life improvement.

This project could really use some TLC. It's past due to be converted to TypeScript along with generating both ESM and CJS bundles. These things should probably happen as part of a 1.0.0 release.

This change reminds me that there is room for improvement on test coverage as well.

=============================== Coverage summary ===============================
Statements   : 89.22% ( 240/269 )
Branches     : 86.55% ( 148/171 )
Functions    : 68.57% ( 24/35 )
Lines        : 88.58% ( 225/254 )
================================================================================

@serbanghita
Copy link
Contributor Author

Thanks for this contribution. Chrome headless and a dev script is a really nice quality of life improvement.

💯

This change reminds me that there is room for improvement on test coverage as well.

Yes, basically if we want new features and fixes, we need a good way to see the coverage.
This needs integration into a public CI like https://travis-ci.org/

@prettymuchbryce prettymuchbryce merged commit 989a995 into prettymuchbryce:master Oct 18, 2020
@prettymuchbryce
Copy link
Owner

Thanks again @serbanghita! I really appreciate these improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants