Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node/3251858] Add index for depth. #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[node/3251858] Add index for depth. #28

wants to merge 1 commit into from

Conversation

simesy
Copy link
Contributor

@simesy simesy commented Nov 30, 2021

Add index for the subquery generated by the Top relationship.
https://www.drupal.org/project/entity_hierarchy/issues/3251858

@simesy
Add index for depth.
632d536 
Add index for the subquery generated by the Top relationship.
@larowlan
Copy link
Member

ping @kimpepper

kimpepper
kimpepper approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@kimpepper kimpepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Are there any other columns that should be added to this index?

@simesy
Copy link
Contributor Author

simesy commented Dec 1, 2021

I'll get @nterbogt to comment as he did the sleuthing.

@nterbogt
Copy link

nterbogt commented Dec 1, 2021

I'd like to continue with a test for depth, left_pos, right_pos and see what comes out of the explain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimpepper kimpepper kimpepper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simesy @larowlan @nterbogt @kimpepper