Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-5017] Assign value to editor children #131

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

aspirisen
Copy link
Contributor

@aspirisen aspirisen self-assigned this Mar 11, 2022
@linear
Copy link

linear bot commented Mar 11, 2022

DEV-5017 Contacts stay in editor after story moved to another newsroom

Summary of the bug:

  • Despite this being a requisite to move a story "This story has inline contacts that will be removed."

    The contacts remain in the editor. They are NOT in the published story though

Intercom conversation link:

Fullstory session link:

URL of page where bug occurred:

Emulation link:

Browser version (customer's):

  • Chrome (98.0.4758.82), Windows 10

----------------

Can we reproduce the bug?

Yes

Reproduce steps:

  1. create story
  2. add contacts
  3. publish or save
  4. move to another newsroom
  5. click that you accept removing inline contacts

Expected result:

  • Inline Contacts should not be there anymore

Actual result:

  • The Editor still shows inline contacts

My reproduction of the issue:

https://rock.prezly.com/stories/459252

chrome_o9ek1c7j9a.png

chrome_Jkwbg6hs4O.png

source story : https://rock.prezly.com/stories/459239

----------------

Engineer's Note:

@aspirisen aspirisen merged commit 931238d into master Mar 15, 2022
@aspirisen aspirisen deleted the fix/DEV-5017-editor-update-value branch March 15, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants