[DEV-13410] Fix - Coverage placeholder search input #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in a smarter way
fgyimah
approved these changes
Nov 4, 2024
yuriyyakym
approved these changes
Nov 4, 2024
| if (container.current) { | ||
| const viewport = document.body.getBoundingClientRect(); | ||
| const rect = container.current.getBoundingClientRect(); | ||
| setMaxHeight(clamp(viewport.height - rect.top - 4, minHeight, maxHeight)); |
There was a problem hiding this comment.
What is 4 magic number? 🤔
There was a problem hiding this comment.
I'm not sure but I think it's probably a bottom padding. I restored this code from how it was before.
I can add a constant for it, but I'm gonna rework these dialogues this week during my project so probably not worth spending extra time on this.
packages/slate-editor/src/components/SearchInput/Suggestions.tsx
Outdated
Show resolved
Hide resolved
yuriyyakym
reviewed
Nov 4, 2024
packages/slate-editor/src/components/SearchInput/Suggestions.tsx
Outdated
Show resolved
Hide resolved
kudlajz
deleted the
feature/dev-13410-pitch-aside-clicking-log-coverage-from-coverage-placeholder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed some problems in the app with the usage of Popper, so I've brought back the minHeight and maxHeight calculation, so Popper doesn't have to flip the entire dropdown unless the available space is less than minHeight.
This makes the dropdown still usable while opened near the bottom of the screen.
There was also a bug with the position of the dropdown when addon is present - this was due to usage of
bottomplacement which anchors to the center of the element (the search input). I've changed it to anchor tobottom-end, so it's always aligned.Another thing that has been fixed is the active element is now properly visible when the dropdown is displayed (previously the active item was sometimes hidden, since the dropdown was scrolled down a bit).