Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-15524] Fix - Make sure FloatingSnippetInput is not re-rendering if not needed #577

Merged

Conversation

kudlajz
Copy link
Contributor

@kudlajz kudlajz commented Jan 10, 2025

  • added useFunction to not create new function references on every render
  • memoized the FloatingSnippetInput component to not re-render if the props haven't changed

@kudlajz kudlajz self-assigned this Jan 10, 2025
Base automatically changed from feature/dev-14744-explore-migrating-to-plate-editor to main January 14, 2025 12:06
@kudlajz kudlajz merged commit 046755a into main Jan 14, 2025
7 checks passed
@kudlajz kudlajz deleted the feature/dev-15524-story-editor-snippet-dropdown-scroll-resets branch January 14, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant