[DEV-11947] Switch theme-kit-js to pnpm
#454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1himself
reviewed
Nov 14, 2023
Comment on lines
+19
to
+37
| - uses: pnpm/action-setup@v2 | ||
| name: Install PNPM | ||
| id: pnpm-install | ||
| with: | ||
| path: "**/node_modules" | ||
| key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }} | ||
| version: 8 | ||
| run_install: false | ||
|
|
||
| - name: Get pnpm store directory | ||
| shell: bash | ||
| run: | | ||
| echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV | ||
|
|
||
| - uses: actions/cache@v3 | ||
| name: Setup pnpm cache | ||
| with: | ||
| path: ${{ env.STORE_PATH }} | ||
| key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-build-${{ env.cache-name }}- | ||
| ${{ runner.os }}-build- | ||
| ${{ runner.os }}- | ||
| ${{ runner.os }}-pnpm-store- |
There was a problem hiding this comment.
We have a reusable Github action to reduce repetitive code in such scenarios:
https://github.com/prezly/setup-github-actions/
e1himself
reviewed
Nov 14, 2023
| @@ -0,0 +1,16622 @@ | |||
| lockfileVersion: '6.0' | |||
There was a problem hiding this comment.
I suggest to ignore this file and not commit it to the repo.
The reasoning I'm basing this suggestion on can be found here:
e1himself
deleted the
feature/dev-11947-switch-theme-kit-nextjs-to-pnpm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.