-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.0.1 배포 테스트 #19
Merged
Merged
v0.0.1 배포 테스트 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- iamport gradle 셋팅 (DI) - iamport YAML 셋팅 (key, secret) - payment controller Class 및 iamport 필드 생성
- 관련 파일 이동
- application.yml s3 profile 분리
- 결제 성공 시, 주문서 생성 API 호출하도록 함
- application-s3.yml 설정 수정
- 불필요 파일 삭제 - BaseEntity에서 BaseTimeEntity로 이름 변경 - Git EOF 방지 마지막 줄 추가
- Javadoc 설명 추가 - 명확한 핸드폰 번호 정규식으로 교체 - 테스트 코드 추가
- build.gradle 수정
[JT-33] 결제 페이지 구축 PR입니다.
- 클래스명 변경 - @controller -> @RestController 어노테이션 변경 - URL 등록
- 원인 : form 태그로 인해 요청이 가지 않음 - 해결 : form 태그 삭제 - 추가 : 요청 성공 후, 즉 결제 승인 후 서버단 추가 로직 작성
- 결제 엔티티 생성 - 결제 저장소 생성 - 결제사를 담을 Enum 생성 - 핵심필드에 대한 null 검증 메서드 생성
- Enum unmodifiable Map 수정 - Enum private 생성자 추가
- 요일로 필터링 구현 - 웹툰 제목, 작가명으로 검색 구현
- exception -> error.exception
- module-domain.application -> module-domain.service 패키지로 변경 - module.application에 application 패키지 생성
- ExceptionCode -> ExceptionStatus
[JT-57] 예외 핸들러 구현하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개발 내용
📑 PR 포인트
👥 협업을 위한 코드리뷰
✅ 리마인더
⚙️ 코드리뷰 룰