Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #39

Closed
wants to merge 3 commits into from
Closed

Main #39

wants to merge 3 commits into from

Conversation

hongdosan
Copy link
Member

πŸ“Œ 개발 λ‚΄μš©

μˆ˜μ • or μΆ”κ°€, 개발된 λ‚΄μš©μ— λŒ€ν•΄μ„œ λͺ…ν™•ν•˜κ²Œ μž‘μ„±λ°”λžλ‹ˆλ‹€.

πŸ“‘ PR 포인트

μ’€ 더 μƒμ„Έν•˜κ²Œ 리뷰 λ°›κ³  싢은 뢀뢄을 κΈ°μž¬ν•΄μ£Όμ„Έμš”.


πŸ‘₯ ν˜‘μ—…μ„ μœ„ν•œ μ½”λ“œλ¦¬λ·°

  1. 세상에 바보같은 μ§ˆλ¬Έμ€ μ—†λ‹€.
  2. μ‹€μˆ˜λ₯Ό μ˜ˆλ°©ν•˜λŠ” νŒ€μ΄ μ•„λ‹ˆλΌ, μ‹€μˆ˜λ₯Ό 잘 λ‹€λ£¨λŠ” νŒ€μ΄ 되자.
  3. 뢄업이 μ•„λ‹Œ ν˜‘μ—…μ„ ν•˜μž. 우린 λͺ¨λ‘ 같은 문제λ₯Ό 이겨내기 μœ„ν•΄ λͺ¨μ˜€λ‹€.
  4. μ˜μ›ν•œ 것은 μ—†μœΌλ‹ˆ λŒ€ν™”λ₯Ό ν•˜μž.
  5. μ„œλ‘œ μ‘΄μ€‘ν•˜μž.
  6. 많이 λΆ€λ”ͺ치고 κΉ¨λ‹«κ³  배우자.
  7. λΆ€λ“œλŸ½κ²Œ μ„€λ“ν•˜κ³  μ—΄λ¦° 마음으둜 μ„€λ“λ‹Ήν•΄λ³΄μž.

βœ… λ¦¬λ§ˆμΈλ”

  • 본인의 λ‘œμ»¬μ—μ„œ 정상 λ™μž‘ν•˜λŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.
  • μ΅œμ‹  브랜치λ₯Ό Pull λ°›κ³  PR을 μš”μ²­ν–ˆλŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.
  • APIκ°€ μΆ”κ°€λ˜μ—ˆμ„ 경우 ν…ŒμŠ€νŠΈλ₯Ό ν•˜κ³  PR을 μ˜¬λ €μ£Όμ„Έμš”.
  • Conflictκ°€ 났을 λ•Œ, UIμƒμ—μ„œ ν•΄κ²°ν•˜μ§€ 말고, 본인 localμ—μ„œ ν•΄κ²°ν•΄μ£Όμ„Έμš”.
  • Commit λ©”μ‹œμ§€ μ œλŒ€λ‘œ μž‘μ„±ν•΄μ£Όμ„Έμš”.

βš™οΈ μ½”λ“œλ¦¬λ·° λ£°

  • R(Request Change): ν•΄λ‹Ή λΈ”λŸ­μ€ κΌ­ λ³€κ²½ν•΄μ£Όμ…¨μœΌλ©΄ μ’‹κ² μŠ΅λ‹ˆλ‹€.
  • C(Comment): μ›¬λ§Œν•˜λ©΄ κ³ λ €ν•΄μ£Όμ‹œλ©΄ μ’‹κ² μŠ΅λ‹ˆλ‹€.
  • Q(Question) : ν•΄λ‹Ή 라인이 κΆκΈˆν•©λ‹ˆλ‹€.
  • A(Approve): λ°˜μ˜ν•΄λ„ μ’‹κ³  λ„˜μ–΄κ°€λ„ μ’‹μŠ΅λ‹ˆλ‹€. ν˜Ήμ€ μ‚¬μ†Œν•œ μ˜κ²¬μž…λ‹ˆλ‹€.

ymkim97 and others added 3 commits September 11, 2023 18:40
hotfix: CORS μ„€μ •
v1.0.5 2차 배포
[JT-65] hotfix: deploy 빈칸 μˆ˜μ •
@hongdosan hongdosan closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants