[JT-29] JWT 로그인 기능 구현 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmebin
approved these changes
Sep 6, 2023
Comment on lines
33
to
34
| member.updateLastLogin(); | ||
| return jwtProvider.generateToken(logInReq.email()); |
There was a problem hiding this comment.
R:
Member member = memberRepository.findByEmail(logInReq.email()).orElseThrow(
() -> new BadCredentialsException("너 안돼!")
);
Member member = memberRepository.findByEmail(logInReq.email())
.orElseThrow(() -> new BadCredentialsException("너 안돼!"));
Comment on lines
24
to
26
| @Override | ||
| protected void doFilterInternal(HttpServletRequest request, @NotNull HttpServletResponse response, | ||
| @NotNull FilterChain filterChain) throws ServletException, IOException { |
Comment on lines
37
to
38
|
|
||
| } |
Comment on lines
29
to
36
| @Value("${jwt.secret.key}") | ||
| private String salt; | ||
|
|
||
| @Value("${jwt.iss}") | ||
| private String iss; | ||
|
|
||
| @Value("${jwt.expire}") | ||
| private long expire; |
There was a problem hiding this comment.
R: 설정 파일에서 @Value로 값 가져오는 경우엔 상수인걸 명시하기 위해서 대문자로 표기하기로 햇슴다!
Comment on lines
60
to
61
| headers.put("typ", "JWT"); | ||
| return headers; |
Comment on lines
67
to
70
| .build().parseClaimsJws(token); | ||
| if (claimsJws.getBody().getExpiration().before(new Date())) { | ||
| throw new RuntimeException("Token Expired"); | ||
| } |
There was a problem hiding this comment.
A: claimsJws.getBody().getExpiration().before(new Date()) 요거 따로 private 메서드로 빼도 좋을 것 같아요! 음 예를들면 isTokenExpired ..
hongdosan
approved these changes
Sep 6, 2023
Comment on lines
33
to
34
| member.updateLastLogin(); | ||
| return jwtProvider.generateToken(logInReq.email()); |
There was a problem hiding this comment.
R:
Member member = memberRepository.findByEmail(logInReq.email()).orElseThrow(
() -> new BadCredentialsException("너 안돼!")
);
Member member = memberRepository.findByEmail(logInReq.email())
.orElseThrow(() -> new BadCredentialsException("너 안돼!"));
Comment on lines
37
to
38
|
|
||
| } |
| String email = Jwts.parserBuilder() | ||
| .setSigningKey(secretKey) | ||
| .build().parseClaimsJws(token).getBody().getSubject(); | ||
|
|
| @Override | ||
| public UserDetails loadUserByUsername(String email) throws UsernameNotFoundException { | ||
| Member member = memberRepository.findByEmail(email).orElseThrow( | ||
| () -> new UsernameNotFoundException("Invalid Email") |
Shin-Jae-Yoon
approved these changes
Sep 6, 2023
| public String login(LogInReq logInReq) { | ||
| Member member = memberRepository.findByEmail(logInReq.email()).orElseThrow( | ||
| () -> new BadCredentialsException("너 안돼!") | ||
| ); |
There was a problem hiding this comment.
R: 요런식으로 많이 썼던 것 같아요 !
Member member = memberRepository.findByEmail(logInReq.email())
.orElseThrow(() -> new BadCredentialsException("너 안돼!"));| public UserDetails loadUserByUsername(String email) throws UsernameNotFoundException { | ||
| Member member = memberRepository.findByEmail(email).orElseThrow( | ||
| () -> new UsernameNotFoundException("Invalid Email") | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개발 내용
📑 PR 포인트
추후 기능
Interceptor와ThreadLocal사용 예정👥 협업을 위한 코드리뷰
✅ 리마인더
⚙️ 코드리뷰 룰