Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿšจ Fix: ์•Œ๋ฆผ ์ƒ์„ฑ ์ „๋‹ฌ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ #128

Merged
merged 8 commits into from
Sep 26, 2023

Conversation

imb96
Copy link
Member

@imb96 imb96 commented Sep 25, 2023

๐Ÿช„ ๋ณ€๊ฒฝ์‚ฌํ•ญ

์•Œ๋ฆผ ํŽ˜์ด์ง€ UI ์ˆ˜์ •
์•Œ๋ฆผ ์—†์Œ ๋ฉ”์‹œ์ง€ ์ถ”๊ฐ€

์•Œ๋ฆผ ์ƒ์„ฑ ์ „๋‹ฌ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ๐Ÿ˜‡

  • ๋Œ“๊ธ€
  • ์ข‹์•„์š”

๐Ÿ–ฅ ๊ฒฐ๊ณผ ํ™”๋ฉด

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-09-26 แ„‹แ…ฉแ„’แ…ฎ 2 57 29

โœ๏ธ PR ํฌ์ธํŠธ

ํŒ”๋กœ์šฐ ์•Œ๋ฆผ์€ ํŒ”๋กœ์šฐ ๋กœ์ง์ด ๋ณ€๊ฒฝ๋˜๊ณ  ๋‚˜์„œ ํ•ด์•ผํ•  ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค.

@imb96 imb96 self-assigned this Sep 25, 2023
@@ -1,7 +1,7 @@
import styled from '@emotion/styled';

const NoticeListContainer = styled.div`
height: calc(100% - 1.5rem);
height: calc(100% - 2rem);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €ํฌ rem์€ ์‚ฌ์šฉํ•˜์ง€ ์•Š๊ธฐ๋กœ ํ–ˆ์Šต๋‹ˆ๋‹ค! px๋กœ ๋ฐ”๊ฟ”์ฃผ์‹œ๋ฉด ์ข‹์„๊ฒƒ ๊ฐ™์•„์š”!

Comment on lines 26 to 27
display: flex;
align-items: center;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme.style.flexAlignCenter๋ฅผ ์‚ฌ์šฉํ•  ์ˆ˜๋„ ์žˆ์Šต๋‹ˆ๋‹ค!

@imb96 imb96 merged commit 53638ce into main Sep 26, 2023
@imb96 imb96 deleted the feat/notice/UI branch September 26, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants