✨ Feat: 회원가입 성공 / 실패 모달창 추가 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
회원가입 성공시 로그인하러 가기 모달창 회원가입 실패시 (중복된 이메일 시도시) 오류 모달창
suyeon1218
reviewed
Sep 8, 2023
src/pages/signup/index.tsx
Outdated
| @@ -5,7 +5,7 @@ import UserInput from '@components/UserInput'; | |||
| import Alert from '@/components/Alert'; | |||
| import { isEmailOk, isNicknameOk, isPasswordOk } from './validations'; | |||
| import { signUpUser } from '@/apis/user/getUserData'; | |||
| import { USERINPUT } from './constants'; | |||
| import { USERINPUT, MODAL } from './constants'; | |||
There was a problem hiding this comment.
USER_INPUT 으로 쓰시는 건 어떠실까요?!
sscoderati
approved these changes
Sep 8, 2023
src/pages/signup/index.tsx
Outdated
Comment on lines
22
to
23
| const [emailError, setEmailError] = useState<boolean>(false); | ||
| const [signupSuccess, setSignupSuccess] = useState<boolean>(false); |
There was a problem hiding this comment.
Suggested change
| const [emailError, setEmailError] = useState<boolean>(false); | |
| const [signupSuccess, setSignupSuccess] = useState<boolean>(false); | |
| const [emailErrorCatched, setEmailErrorCatched] = useState<boolean>(false); | |
| const [signupSuccessed, setSignupSuccessed] = useState<boolean>(false); |
boolean값에 걸맞는 네이밍 제안드립니다!
| const [passwordConfirm, setPasswordConfirm] = useState<string>(''); | ||
| const [emailError, setEmailError] = useState<boolean>(false); | ||
| const [signupSuccess, setSignupSuccess] = useState<boolean>(false); | ||
| const navigate = useNavigate(); | ||
| let timer = 0; |
suyeon1218
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪄 변경사항
회원가입 성공 / 실패 모달창 출력
🖥 결과 화면
✏️ PR 포인트
회원가입 성공시 로그인하러 가기 모달창이 출력되며 로그인하러 가기 버튼을 누르면 'login'페이지로 이동합니다.
중복된 이메일으로 회원가입 시도시 오류 모달창이 출력되며 확인 버튼을 누르면 모달창이 닫히고 다시 회원가입할 수 있습니다.