Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿšจ Fix: validation ํ”„๋กœํผํ‹ฐ ๋„˜๊ฒจ์ฃผ์ง€ ์•Š์€ ๋ฌธ์ œ ์ˆ˜์ • #73

Merged
merged 1 commit into from
Sep 25, 2023
Merged

๐Ÿšจ Fix: validation ํ”„๋กœํผํ‹ฐ ๋„˜๊ฒจ์ฃผ์ง€ ์•Š์€ ๋ฌธ์ œ ์ˆ˜์ • #73

merged 1 commit into from
Sep 25, 2023

Conversation

suyeon1218
Copy link
Collaborator

๐Ÿช„ ๋ณ€๊ฒฝ์‚ฌํ•ญ

์•„๋ž˜ ์˜ค๋ฅ˜ ์‚ฌํ•ญ์„ ํ•ด๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.

useNavigate

useNavigate ๋ฅผ ์„ ์–ธํ•˜์ง€ ์•Š๊ณ  navigate Function ์„ ํ˜ธ์ถœํ•œ ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. (merge ๋ฌธ์ œ)

NewPost prop

posting ํŽ˜์ด์ง€๋กœ ์ž„์˜๋กœ ์ ‘๊ทผํ•  ์‹œ ๊ตฌ์กฐ๋ถ„ํ•ด ํ• ๋‹น์ด ์•ˆ๋˜๋Š” ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ•˜๋ฉด์„œ ๋ฅผNewPost ์— ์ž˜๋ชป๋œ prop ์„ ๋„˜๊ฒจ์ฃผ๋Š” ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ–ฅ ๊ฒฐ๊ณผ ํ™”๋ฉด

์ƒ๋žตํ•ฉ๋‹ˆ๋‹ค.

โœ๏ธ PR ํฌ์ธํŠธ

์ƒ๋žตํ•ฉ๋‹ˆ๋‹ค.

@suyeon1218 suyeon1218 self-assigned this Sep 22, 2023
imb96
imb96 approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@imb96 imb96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๐Ÿ‘

@suyeon1218 suyeon1218 merged commit 2b6ab14 into main Sep 25, 2023
@suyeon1218 suyeon1218 deleted the fix/posting/error branch September 25, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imb96 imb96 imb96 approved these changes

@hyesung99 hyesung99 hyesung99 approved these changes

Assignees

@suyeon1218 suyeon1218

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suyeon1218 @hyesung99 @imb96