✨Feat: search/debounce 등.. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IRVANA_Gidong into feat/search/style
…IRVANA_Gidong into feat/search/style
…IRVANA_Gidong into feat/search/style
…IRVANA_Gidong into feat/search/style
suyeon1218
approved these changes
Sep 23, 2023
src/apis/user/index.ts
Outdated
| const getUser = async (userId: string) => { | ||
| const response = await axios.get(`${API_BASE_URL}/users/${userId}`); | ||
| const getUser = async (userId: string | User) => { | ||
| const response = await axios.get<User>(`${API_BASE_URL}/users/${userId}`); |
There was a problem hiding this comment.
p3
const url = `${API_BASE_URL}/users/${userId}`로 따로 빼내어 사용하는 건 어떻게 생각하실까요?
There was a problem hiding this comment.
혜성님의 코드여서 혜성님을 소환하겠습니다! @hyesung99
Closed
hyesung99
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪄 변경사항
🖥 결과 화면
짜잔!
✏️ PR 포인트