Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

When resizing an element along just the y-axis, the element's x-coord should not snap to the grid automatically #720

Closed
nathanielw opened this issue Jul 16, 2015 · 0 comments
Labels
Milestone

Comments

@nathanielw
Copy link
Contributor

Currently, if you have an object positioned so that it is not aligned perfectly with the grid (e.g. positioned using the arrow keys or as a result of snapping to something else not on the grid), resizing with the vertical handles will also resize the shape horizontally, snapping it to the nearest grid line.

This is definitely unexpected behaviour, since the user is explicitly trying to resize in a single direction.

From a brief play around, it seems this is caused by the GeometryEditor.handleMouseMove function calling Util.gridNormalize(...) on the newX (and newX2) variables without actually checking if the resize should be altering the width at all. (this is all in app/editor/geometryEditor.js, around line 400)

This should be a simple fix, so I'll try to get a PR up when I have time in the next few days.

@prikhi prikhi closed this as completed in 35c84ae Jul 18, 2015
prikhi added a commit that referenced this issue Jul 18, 2015
Fixes #720 - bug where scaling along just the y-axis caused the shape to snap to the grid along the x axis as well.
@prikhi prikhi added the bug label Jul 18, 2015
@prikhi prikhi added this to the v2.1.0 milestone Jul 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants