This repository has been archived by the owner on Sep 7, 2024. It is now read-only.
solve bug fixed size in svg export #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prikhi
added a commit
that referenced
this pull request
Jul 18, 2015
[#538] solve bug fixed size in svg export
|
Sorry for the delay, I thought github would email me when PRs were opened... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Pencil exports a SVG file, then the result contains attributes with a fixed size.
In the SVG export file, the first element is:
<svg xmlns="..." width="744.09448819" height="1052.3622047" .....
These dimensions are wrong. Adapting these two values fixes the problem that you will have when using the svg result: If the drawing is bigger, a part is cut of, and if the drawing is smaller, you have too much white space.
See also https://code.google.com/p/evoluspencil/issues/detail?id=456
See also https://code.google.com/p/evoluspencil/issues/detail?id=538
This patch uses the dimensions of the first page for all its pages.
Remark about the multipage aspect:
SVG does not support multiple pages.
Pencil uses the Inkscape extension for multiple layers.
That means that when you view the resulting SVG file in a browser, all pages appear on top of each other.
So, creating a .ep file with multiple pages seems not very usefull to me.
If your .ep files only contain 1 page, then the SVG export function is perfect with this patch.