Support auth0 ex #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreapavoni
previously approved these changes
Nov 16, 2021
lib/graphql.ex
Outdated
| @@ -49,6 +55,15 @@ defmodule BridgeEx.Graphql do | |||
| else | |||
| defp format_response({ret, response}), do: {ret, response} | |||
| end | |||
|
|
|||
| defp with_authorization_headers(headers, nil), do: {:ok, headers} | |||
There was a problem hiding this comment.
Visto che sei in una macro non vale la pena di compilare direttamete la funzione come fa sopra?
There was a problem hiding this comment.
Grazie ❤️
Se ho capito bene il punto, dovrebbe essere risolto con 105a71f
dallagi
force-pushed
the
support_auth0_ex
branch
from
6abdfba to
105a71f
Compare
cottinisimone
previously approved these changes
Nov 16, 2021
mbusi
previously approved these changes
Dec 2, 2021
mbusi
force-pushed
the
support_auth0_ex
branch
from
a377227 to
82c37b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for authentication of machine to machine communication via
auth0_ex.To use this feature, clients need to set
audience: "target-service"as an option when theyusethe bridge.For the moment we approached testing with a black-box approach, in order to limit the changes to the previous implementation.
The build on drone is currently broken, as
auth0_exis a private repository and drone cannot reach it - until we fix it.NOTE: This PR also fixes a typo in the configuration of the bridge, from
max_attempstomax_attempts: we need to make sure that current users are not using the "typoed" configuration before updating this library for them.