Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export component UTF-8 file name support #1603

Closed
JasonQuan opened this issue Jul 15, 2016 · 1 comment
Closed

export component UTF-8 file name support #1603

JasonQuan opened this issue Jul 15, 2016 · 1 comment
Assignees
@tandraschko
Labels
enhancement Additional functionality to current component
Milestone
6.1

Comments

@JasonQuan
Copy link

JasonQuan commented Jul 15, 2016 •
edited
Loading

PF version 6.0
org.primefaces.component.export.ExcelExporter.java

protected String getContentDisposition(String filename){
return "attachment;filename="+URLEncoder.encode(filename,"UTF-8")+".xls";
}
@JasonQuan JasonQuan changed the title export component chinese file name support export component UTF-8 file name support Jul 15, 2016
tandraschko added a commit that referenced this issue Aug 21, 2016
@tandraschko
#1603
cc3adc3
@tandraschko tandraschko added the enhancement Additional functionality to current component label Aug 21, 2016
@tandraschko tandraschko added this to the 6.1 milestone Aug 21, 2016
@tandraschko tandraschko self-assigned this Aug 21, 2016
@GithubJohn3031
Copy link

GithubJohn3031 commented Aug 24, 2016 •
edited
Loading

This solution doesn't work correctly if filename contains spaces or some other characters. Please see: #1312

@melloware melloware mentioned this issue May 15, 2017
Merged
tandraschko added a commit that referenced this issue May 22, 2017
@tandraschko
Merge pull request #2368 from melloware/PF1312
35637c2 
Fix #1312 and #1603 RFC6266 encoding of Content-Disposition headers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tandraschko tandraschko

Labels
enhancement Additional functionality to current component
Projects
None yet
Milestone
6.1
Development

No branches or pull requests
3 participants
@tandraschko @JasonQuan @GithubJohn3031