Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: column-filter outside click does not close when it is inside a dialog component #16020

Closed
ymg2006 opened this issue Jul 13, 2024 · 0 comments · May be fixed by Rodolphe33/gestion-personnel#20, Rodolphe33/gestion-personnel#21, Rodolphe33/gestion-personnel#23, Rodolphe33/gestion-personnel#24 or Rodolphe33/gestion-personnel#25
Closed

Table: column-filter outside click does not close when it is inside a dialog component #16020

ymg2006 opened this issue Jul 13, 2024 · 0 comments · May be fixed by Rodolphe33/gestion-personnel#20, Rodolphe33/gestion-personnel#21, Rodolphe33/gestion-personnel#23, Rodolphe33/gestion-personnel#24 or Rodolphe33/gestion-personnel#25
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working

Comments

@ymg2006
Copy link
Contributor

ymg2006 commented Jul 13, 2024

Describe the bug

put a table and a column filter inside dialog
click to open filter menu
it will not hide event if you close the modal

Environment

Windows

Reproducer

https://stackblitz.com/edit/github-978vwo

Angular version

17.3.8

PrimeNG version

17.8.4

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.12.1

Browser(s)

All

Steps to reproduce the behavior

put a table and a column filter inside dialog
click to open filter menu
it will not hide event if you close the modal

Expected behavior

close the modal on outside click
@ymg2006 ymg2006 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 13, 2024
@ymg2006 ymg2006 mentioned this issue Jul 13, 2024
Merged
ymg2006 pushed a commit to ymg2006/primeng that referenced this issue Jul 21, 2024
@codizen-dev
queried the date-picker class to fix the issue
33def4e 
fixes primefaces#16020 without breaking the primefaces#14987
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 25, 2024
cetincakiroglu added a commit that referenced this issue Jul 25, 2024
@cetincakiroglu
Merge pull request #16021 from ymg2006/filterDialog-outsideclick
489d966 
fixes #16020 Table: column-filter outside click does not close when it is inside a dialog component
This was referenced Aug 16, 2024
Open
Open
This was referenced Aug 30, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Sep 20, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
No milestone
2 participants
@ymg2006 @cetincakiroglu