Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: the style of the toolbar is missing up when custom modules used #16114

Closed
its-dibo opened this issue Jul 27, 2024 · 1 comment · Fixed by #16357 · May be fixed by Rodolphe33/gestion-personnel#33
Closed

Editor: the style of the toolbar is missing up when custom modules used #16114

its-dibo opened this issue Jul 27, 2024 · 1 comment · Fixed by #16357 · May be fixed by Rodolphe33/gestion-personnel#33
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Milestone
17.18.10

Comments

@its-dibo
Copy link

its-dibo commented Jul 27, 2024 •
edited
Loading

Describe the bug

when adding custom modules using [modules] = "modules" the editor's style is damged

see this demo

code

Reproducer

https://stackblitz.com/edit/primeng-editor-demo-z8agrd?file=src%2Fapp%2Fapp.component.html

Angular version

18

PrimeNG version

17.18.6

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

chrome

Steps to reproduce the behavior

No response

Expected behavior

No response
@its-dibo its-dibo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 27, 2024
renanvieiraa added a commit to renanvieiraa/primeng that referenced this issue Sep 8, 2024
@renanvieiraa
Fixed primefaces#16114 - Editor | hide primeng toolbar when insert qu…
27dca93 
…ill modules.
@renanvieiraa renanvieiraa mentioned this issue Sep 8, 2024
Merged
@renanvieiraa
Copy link
Contributor

You can hide this by inserting an empty pTemplate header into the p-editor tag to trigger the ‘template element’ and hide the PrimeNG toolbar.

I've fixed this in #16357

<p-editor
  [style]="{ height: '320px' }"
  [modules]="modulesInEditor"
>
  <ng-template pTemplate="header"> </ng-template>
</p-editor>

@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 10, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.10 milestone Sep 10, 2024
mehmetcetin01140 added a commit that referenced this issue Sep 10, 2024
@mehmetcetin01140
Merge pull request #16357 from renanvieiraa/issue-16114
524bbd7 
Fixed #16114 - Editor | hide primeng toolbar when insert quill modules.
@Rodolphe33 Rodolphe33 mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Projects
None yet
Milestone
17.18.10
3 participants
@renanvieiraa @its-dibo @mehmetcetin01140