Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListBox component accessibility issues #16152

Closed
andrey-post opened this issue Aug 1, 2024 · 0 comments · Fixed by #16183 · 4 remaining pull requests
Closed

ListBox component accessibility issues #16152

andrey-post opened this issue Aug 1, 2024 · 0 comments · Fixed by #16183 · 4 remaining pull requests
Assignees
@mehmetcetin01140
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE LTS-FIXED-16.9.15 PRO Support Issue was reported by PRO User v18-port
Milestone
17.18.8

Comments

@andrey-post
Copy link

andrey-post commented Aug 1, 2024 •
edited
Loading

Describe the bug

ListBox component accessibility violations:

  1. Scrollable region must have keyboard access
  2. ARIA hidden element must not be focusable or contain focusable elements

image
image

Environment

Latest Chrome on Windows 10, Angular CLI project with Angular@17.3.12 and PrimeNG@17.18.6

Reproducer

No response

Angular version

17.3.12

PrimeNG version

17.18.6

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.2

Browser(s)

No response

Steps to reproduce the behavior

  1. Open https://primeng.org/listbox
  2. Scan with Axe Dev Tools accessibility scanner

Expected behavior

No critical or serious accessibility issues coming from the inside of the component.
@andrey-post andrey-post added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 1, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Aug 2, 2024
@mehmetcetin01140 mehmetcetin01140 added PRO Support Issue was reported by PRO User Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 2, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.8 milestone Aug 7, 2024
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Aug 7, 2024
Merged
cetincakiroglu added a commit that referenced this issue Aug 8, 2024
@cetincakiroglu
Merge pull request #16183 from primefaces/issue-16152
8c6e585 
Fixed #16152 - ListBox component accessibility issues
This was referenced Aug 30, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Sep 20, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Oct 2, 2024
Open
mehmetcetin01140 added a commit that referenced this issue Nov 12, 2024
@mehmetcetin01140
Fixed #16152 - ListBox component accessibility issues
30fa301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE LTS-FIXED-16.9.15 PRO Support Issue was reported by PRO User v18-port
Projects
None yet
Milestone
17.18.8
2 participants
@mehmetcetin01140 @andrey-post