Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: console.error when selecting a menu item with keyboard #16219

Closed
andrey-post opened this issue Aug 13, 2024 · 0 comments · Fixed by #16221 · 4 remaining pull requests
Closed

Menu: console.error when selecting a menu item with keyboard #16219

andrey-post opened this issue Aug 13, 2024 · 0 comments · Fixed by #16221 · 4 remaining pull requests
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.9

Comments

@andrey-post
Copy link

Describe the bug

There's an unexpected error in the console when a menu item is selected with keyboard navigation (Enter key):

chrome_L7Qg6lXMsX
image

Environment

Latest Chrome on Windows

Reproducer

No response

Angular version

17.3.12

PrimeNG version

17.18.8

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.2

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primeng.org/menu#popup
  2. Use Tab to focus the menu button, hit Enter to open the menu
  3. Select any item with keyboard Arrows, hit Enter
  4. Observe an error in the console

Expected behavior

No errors in the console.
CI should fail if console.* methods are unexpectedly called during tests execution.
@andrey-post andrey-post added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 13, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Aug 13, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 13, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.9 milestone Aug 13, 2024
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Aug 13, 2024
Merged
cetincakiroglu added a commit that referenced this issue Aug 15, 2024
@cetincakiroglu
Merge pull request #16221 from primefaces/issue-16219
7dac62a 
Fixed #16219 - Menu: console.error when selecting a menu item with ke…
This was referenced Sep 6, 2024
Open
Open
This was referenced Sep 14, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Oct 2, 2024
Open
mehmetcetin01140 added a commit that referenced this issue Nov 11, 2024
@mehmetcetin01140
Fixed #16219 - Menu: console.error when selecting a menu item with ke…
12fd141 
…yboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.9
2 participants
@mehmetcetin01140 @andrey-post