Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data filter and sorting issue on v18 table #16360

Closed
hm-kynecto opened this issue Sep 9, 2024 · 0 comments
Closed

Data filter and sorting issue on v18 table #16360

hm-kynecto opened this issue Sep 9, 2024 · 0 comments
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
18.0.0-rc.2

Comments

@hm-kynecto
Copy link

Describe the bug

If using both sorting and column filter then a space bar causes the sort to trigger and doesnt allow a space in the search field

 <th pSortableColumn="updatedByUsername" style="width:25%">
                <span>Updated By</span>
                <p-sortIcon field="updatedByUsername" class="ml-2"></p-sortIcon>
                <p-columnFilter
                  type="text"
                  field="updatedByUsername"
                  placeholder="Search by User"
                  ariaLabel="Filter Updated By"></p-columnFilter>
              </th>

Environment

development

Reproducer

No response

Angular version

18.0.0

PrimeNG version

18.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@hm-kynecto hm-kynecto added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 9, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Oct 26, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan removed this from PrimeNG Nov 20, 2024
mehmetcetin01140 added a commit that referenced this issue Nov 22, 2024
@mehmetcetin01140
Fixed #16360 | Data filter and sorting issue on v18 table
4bb745d
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Nov 22, 2024
Merged
mehmetcetin01140 added a commit that referenced this issue Nov 22, 2024
@mehmetcetin01140
Merge pull request #16820 from primefaces/issue-16360
1b6eb82 
Fixed #16360 | Data filter and sorting issue on v18 table
@mehmetcetin01140 mehmetcetin01140 closed this as completed by moving to Done in PrimeNG Nov 22, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
18.0.0-rc.2
Development

No branches or pull requests
4 participants
@mertsincan @cetincakiroglu @mehmetcetin01140 @hm-kynecto