Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-splitter: zero width panel parsed as null #16425

Closed
askberentsen opened this issue Sep 24, 2024 · 0 comments · Fixed by #16426
Closed

p-splitter: zero width panel parsed as null #16425

askberentsen opened this issue Sep 24, 2024 · 0 comments · Fixed by #16426
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.11

Comments

@askberentsen
Copy link
Contributor

Describe the bug

the p-splitter incorrectly parses zero width panels as null, and defaults 0 to the default value.

Environment

Windows 11

Reproducer

No response

Angular version

18.2.0

PrimeNG version

17.18.9

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.16.0

Browser(s)

No response

Steps to reproduce the behavior

set panelSizes to [100, 0]
instead it is set to [100, 50]

Expected behavior

panelSizes to be set to [100, 0]
@askberentsen askberentsen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 24, 2024
@askberentsen askberentsen mentioned this issue Sep 24, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 26, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.11 milestone Sep 26, 2024
cetincakiroglu added a commit that referenced this issue Sep 26, 2024
@cetincakiroglu
Merge pull request #16426 from askberentsen/patch-1
3fea0b9 
Enabled splitter to support zero width panels #16425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.11
Development

Successfully merging a pull request may close this issue.

Enabled splitter to support zero width panels #16425 askberentsen/primeng
2 participants
@askberentsen @cetincakiroglu