Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependencies with A2-beta.15 incompatible? #205

Closed
luchillo17 opened this issue Apr 14, 2016 · 7 comments
Closed

Peer dependencies with A2-beta.15 incompatible? #205

luchillo17 opened this issue Apr 14, 2016 · 7 comments

Comments

@luchillo17
Copy link

Just installed PrimeNg and npm complains about peer deps, A2-beta.15 requires zone.js@^0.6.10 while PrimeNg requires exactly 0.6.6 so if i fulfil A2 deps i fail to fulfil Zone.js version for PrimeNg peer dependency, can this be updated or fixed to '@^0.6.6'.

Also PrimeNg complains for a peer dep on System.js but i'm using webpack, shouldn't be a choice of the user which bundler to use?

@cesarrew
Copy link

#204

@cagataycivici
Copy link
Member

See #206 please.

@luchillo17
Copy link
Author

Cool, when will beta.3 arrive?

@cagataycivici
Copy link
Member

Should be mid next week.

@luchillo17
Copy link
Author

@cagataycivici I notice that most lib makers use hard peer dependencies on certain versions of other libs, in primeng@1.0.0-beta.4 case is angular2@2.0.0-beta.17, is it really a hard dependency? do primeng beta.0 break if used with angular2@2.0.0-beta.16 or 15or 14?

As far as i know peer dependencies are meant to tell the user what's the minimum version of the other libs that this one needs to work properly, if it's indeed angular2@2.0.0-beta.17 the minimum, at least put it as angular2@^2.0.0-beta.17 in order to allow for future Angular 2 versions.

@cagataycivici
Copy link
Member

Yes it will break due to some breaking changes in beta 17 so at least beta 17 is required.

@cagataycivici
Copy link
Member

Sure we will add at least symbol for next primeng beta releas3. Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants