Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown throwing error on empty selectitem array #220

Closed
ljubomir opened this issue Apr 18, 2016 · 1 comment
Closed

Dropdown throwing error on empty selectitem array #220

ljubomir opened this issue Apr 18, 2016 · 1 comment
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
1.0.0-beta.3

Comments

@ljubomir
Copy link

After the latest update, all of my Dropdown components are throwing the following error:

EXCEPTION: TypeError: Cannot read property 'label' of undefined in ...

I assume is because of the updateLabel() invoked on ngOnInit().
IMHO additional check for empty array might help resolve this issue..

I'm using primeng 1.0.0-beta.2 with Angular 2.0.0-beta.15
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 18, 2016
@cagataycivici cagataycivici added this to the 1.0.0-beta.3 milestone Apr 18, 2016
@cagataycivici cagataycivici self-assigned this Apr 18, 2016
@cagataycivici
Copy link
Member

Will review and give an update.

@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 19, 2016
@cagataycivici cagataycivici changed the title Dropdown comoponent throwing error on empty selectitem array Dropdown throwing error on empty selectitem array Apr 19, 2016
atretyak1985 added a commit to Nanitor/primeng that referenced this issue Jul 18, 2020
@atretyak1985 @gunnsth
Device detail - Show subnet ip addresses primefaces#195 (primefaces#220)
29933d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
1.0.0-beta.3
Development

No branches or pull requests
2 participants
@ljubomir @cagataycivici