Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive Lightbox #2318

Closed
bogacg opened this issue Mar 16, 2017 · 3 comments
Closed

Responsive Lightbox #2318

bogacg opened this issue Mar 16, 2017 · 3 comments
Assignees
@yigitfindikli
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
8.0.1

Comments

@bogacg
Copy link

bogacg commented Mar 16, 2017

I'm submitting a ...

[X] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap

Current behavior
Full size lightbox images are displayed in given size as is, even on mobile devices. If image size is larger than available window size, image visibile area is cropped & centered (but not really centered, there seems to be some padding)

Expected behavior
It would be nice to have responsive attribute, if defined fits image by width, to available window area.

Minimal reproduction of the problem with instructions
Docs Lightbox

What is the motivation / use case for changing the behavior?
Better mobile experience
@cagataycivici
Copy link
Member

cagataycivici commented Jun 20, 2017 •
edited
Loading

Agreed

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jun 20, 2017
@cagataycivici cagataycivici mentioned this issue Jun 28, 2017
Closed
@bossqone
Copy link
Contributor

any updates?

@livevie
Copy link

livevie commented Aug 22, 2018

now updates?

@JacobSiegle JacobSiegle mentioned this issue Oct 2, 2018
Closed
gasparbarancelli pushed a commit to gasparbarancelli/primeng that referenced this issue Jan 8, 2019
primefaces#2318
cdf74de
cagataycivici added a commit that referenced this issue Jan 23, 2019
@cagataycivici
Merge pull request #7097 from gasparbarancelli/2318
dfddc24 
Responsive Lightbox #2318
@cagataycivici cagataycivici self-assigned this Jan 23, 2019
@cagataycivici cagataycivici modified the milestone: 7.0.5 Jan 23, 2019
@cagataycivici cagataycivici added this to the 8.0.1 milestone Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
8.0.1
Development

No branches or pull requests
5 participants
@bossqone @cagataycivici @bogacg @livevie @yigitfindikli