Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlaypanel need a double click on the body to close it, if the event that call show() is not a click event #2380

Closed
Tuizi opened this issue Mar 24, 2017 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Tuizi
Copy link

Tuizi commented Mar 24, 2017

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.

http://plnkr.co/edit/rFg3asM7Cqx1s1UaXeBt

Current behavior

You need to double click on the body if you want to close an overlay opened after a even other than a click

Expected behavior

We should be able to hide the Overlay independently of the event that opened it

Minimal reproduction of the problem with instructions

See the plunkr few lines of code are enough to reproduce it.

What is the motivation / use case for changing the behavior?

I want to display the overlay panel when an user type something in a <input> for example

Please tell us about your environment:

MacOSX, Webstorm, yarn, nodejs

  • Angular version: 2.0.X

2.4.10

  • PrimeNG version: 2.0.X

2.0.4

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Typescript

  • Node (for AoT issues): node --version =

@meiriko
Copy link

meiriko commented Jun 6, 2017

+1

The reason is that the onInit "eats" the first document click (assuming it is the triggering event). Didn't have time to further investigate or create a PR

@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 22, 2017
@anafreitas
Copy link

any updates on this?

@edgar131
Copy link

+1 Very annoying. I'm trying to show the panel on hover, but because of that it requires a double click to get it to close. There also doesn't seem to be a easy way to handle closing it on mouseout of the panel.

@Tuizi Tuizi changed the title Overlaypanel need a double click on the body to close it, if the even that call show() is not a click event Overlaypanel need a double click on the body to close it, if the event that call show() is not a click event Sep 29, 2017
@cagataycivici cagataycivici self-assigned this Oct 19, 2017
@cagataycivici cagataycivici added this to the 4.2.3 milestone Oct 19, 2017
cagataycivici pushed a commit that referenced this issue Oct 24, 2017
@andreyshedko
Copy link

The problem still exists in 9.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

6 participants