Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onSlideEnd event is not getting values on range mode #2429

Closed
seyidyagmur opened this issue Mar 31, 2017 · 2 comments
Closed

onSlideEnd event is not getting values on range mode #2429

seyidyagmur opened this issue Mar 31, 2017 · 2 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.2

Comments

@seyidyagmur
Copy link

When I use p-slider element with [range] attribute, I can not get the values via (onSlideEnd)
event.But if I use (onChange) instead, I can get the values or once I use p-slider without [range] I can get the values with this attribute (onSlideEnd) as well.
The bug I want to explain is available on the link below.
http://plnkr.co/edit/JacrFoQ79yjuRAjSfU4w?p=preview

<p-slider (onSlideEnd)="changeFilterRange($event)" [(ngModel)]="filterRangeValues" [style]="{'width':'100%'}" [range]="true"></p-slider>

  • Angular version: 2.3.1
  • PrimeNG version: 2.0.1

regards..
mnjongerius added a commit to mnjongerius/primeng that referenced this issue May 19, 2017
@mnjongerius
Update slider.ts
e0613d8 
Fixed issue: primefaces#2429
@mnjongerius mnjongerius mentioned this issue May 19, 2017
Merged
@mnjongerius
Copy link
Contributor

I fixed this in e0613d8 (#2829)

@mnjongerius mnjongerius mentioned this issue May 19, 2017
Merged
@cagataycivici cagataycivici changed the title onSlideEnd event is not getting values onSlideEnd event is not getting values on range mode May 26, 2017
@cagataycivici cagataycivici self-assigned this May 26, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 26, 2017
@cagataycivici cagataycivici added this to the 4.0.2 milestone May 26, 2017
cagataycivici added a commit that referenced this issue May 26, 2017
@cagataycivici
Merge pull request #2829 from mnjongerius/patch-1
058919e 
Fixed: onSlideEnd event is not getting values #2429
@cagataycivici
Copy link
Member

Fixed via the PR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.2
Development

No branches or pull requests
3 participants
@cagataycivici @mnjongerius @seyidyagmur